Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sketching prototype pt1 - module (WPB-6243) #2811

Merged
merged 29 commits into from
Apr 5, 2024
Merged

feat: sketching prototype pt1 - module (WPB-6243) #2811

merged 29 commits into from
Apr 5, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Mar 25, 2024 •
edited by github-actions bot
Loading

SpikeWPB-6243 Sending Sketches

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to implement sending sketches (drawing on a white Canvas)

Causes (Optional)

Not implemented

Solutions

Implement in several smaller PR's.

This PR:

  • Creates a new feature module for sketches, so we can start dealing with this and build the necessary infra and boilerplate for it.
  • Adds a script and a template "directory" so we can modify and replicate easily in the future.
  • Modifiy gradle settings.gradle.kts file to include automatically new modules, following this pattern.

Depends on

Enhancements can be addressed after all of the above done

  • Add toolbar and change strokes and colors, in another PR, this can be merged later, not blocker to merge the above.

Attachments (Optional)

Script example usage creating a module commons

render1711525846966-ezgif.com-gif-to-mp4-converter.mp4
Screenshot 2024-03-27 at 08 53 53

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

yamilmedina
yamilmedina commented Mar 25, 2024
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
yamilmedina
yamilmedina commented Mar 25, 2024
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
@yamilmedina yamilmedina changed the title feat: sketching prototype pt1 (module) feat: sketching prototype pt1 - module Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

Test Results

880 tests  +2   880 ✅ +2   12m 41s ⏱️ - 3m 22s
122 suites +2     0 💤 ±0 
122 files   +2     0 ❌ ±0 

Results for commit 925af74. ± Comparison against base commit 930b7af.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina changed the title feat: sketching prototype pt1 - module feat: sketching prototype pt1 - module (WPB-6243) Mar 27, 2024
@AndroidBob
Copy link
Collaborator

Build 3890 succeeded.

The build produced the following APK's:

vitorhugods
vitorhugods approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved it!

Just small suggestions/thoughts that can be tackled later.

features/sketch/build.gradle.kts Outdated Show resolved Hide resolved
features/sketch/build.gradle.kts Outdated Show resolved Hide resolved
features/sketch/build.gradle.kts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (2d77b2f) to head (1db7a57).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2811      +/-   ##
===========================================
- Coverage    43.80%   43.75%   -0.05%     
===========================================
  Files          424      424              
  Lines        14066    14066              
  Branches      2501     2501              
===========================================
- Hits          6161     6155       -6     
- Misses        7187     7194       +7     
+ Partials       718      717       -1

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d77b2f...1db7a57. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3917 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3921 failed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3948 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4015 failed.

@pull-request-size pull-request-size bot added size/XL and removed size/M labels Apr 5, 2024
@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@yamilmedina yamilmedina enabled auto-merge April 5, 2024 17:38
@AndroidBob
Copy link
Collaborator

Build 4023 failed.

@yamilmedina yamilmedina added this pull request to the merge queue Apr 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit ad1880f Apr 5, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the feat/sketching-proto-pt1 branch April 5, 2024 18:31
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yamilmedina @AndroidBob @codecov-commenter @alexandreferris @vitorhugods @Garzas