Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update last read message on conversation opening [WPB-7208] #2822

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Mar 26, 2024

BugWPB-7208 [Android] Conversations not being marked as read until I send a message

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user opens conversation screen messages are not being marked as read until user will scroll.

Solutions

Additional LauncherEffect to be triggered at start to mark latest message as read

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 26, 2024
Copy link
Contributor

github-actions bot commented Mar 26, 2024

Test Results

878 tests  ±0   878 ✅ ±0   11m 29s ⏱️ -37s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit c2f2644. ± Comparison against base commit 8dbc70d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3765 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3785 failed.

@Garzas Garzas enabled auto-merge March 27, 2024 19:43
@Garzas Garzas added this pull request to the merge queue Mar 27, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2024
@AndroidBob
Copy link
Collaborator Author

Build 3805 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3834 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3880 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Apr 2, 2024
Merged via the queue into develop with commit f24c968 Apr 2, 2024
14 checks passed
@Garzas Garzas deleted the fix/update-last-read-message-on-start-cherry-pick branch April 2, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants