Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle uri asset #2827

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 27, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • moved handling asset uri functionality to separate use case to make same functionality for SendMessageViewModel and ImportMediaAuthenticatedViewModel
  • made AssetBundle more universal

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Test Results

878 tests  +878   878 ✅ +878   9m 53s ⏱️ + 9m 53s
120 suites +120     0 💤 ±  0 
120 files   +120     0 ❌ ±  0 

Results for commit 9fb5484. ± Comparison against base commit bdac706.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3784 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🏅

@AndroidBob
Copy link
Collaborator

Build 3796 succeeded.

The build produced the following APK's:

private val sendAssetMessage: ScheduleNewAssetMessageUseCase,
private val sendTextMessage: SendTextMessageUseCase,
private val kaliumFileSystem: KaliumFileSystem,
private val getAssetSizeLimit: GetAssetSizeLimitUseCase,
private val handleUriAssetUseCase: HandleUriAssetUseCase,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private val handleUriAssetUseCase: HandleUriAssetUseCase,
private val handleUriAsset: HandleUriAssetUseCase,

@@ -281,14 +275,14 @@ class ImportMediaAuthenticatedViewModel @Inject constructor(

suspend fun handleReceivedDataFromSharingIntent(activity: AppCompatActivity) {
val incomingIntent = ShareCompat.IntentReader(activity)
appLogger.e("Received data from sharing intent ${incomingIntent.streamCount}")
appLogger.i("Received data from sharing intent ${incomingIntent.streamCount}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Garzas Garzas merged commit 94cb684 into chore/extract-send-message-to-viemodel Mar 27, 2024
7 checks passed
@Garzas Garzas deleted the chore/handle-uri-asset branch March 27, 2024 14:56
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants