Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conversation options divider [WPB-3985] #2840

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: conversation options divider [WPB-3985] #2840

merged 3 commits into from
Apr 2, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 29, 2024 •
edited by github-actions bot
Loading

BugWPB-3985 [Android] Divider lines are missing in conversation details / options view

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • added dividers to conversation options
  • updated some deprecated Dividers

@Garzas Garzas requested review from borichellow and saleniuk March 29, 2024 15:15
@Garzas Garzas self-assigned this Mar 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 29, 2024 •
edited
Loading

Test Results

878 tests  ±0   878 ✅ ±0   14m 19s ⏱️ + 2m 13s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit 1f45643. ± Comparison against base commit 8dbc70d.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3871 failed.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3875 succeeded.

The build produced the following APK's:

@Garzas Garzas requested a review from alexandreferris April 2, 2024 06:52
@Garzas Garzas added this pull request to the merge queue Apr 2, 2024
Merged via the queue into develop with commit e2cc137 Apr 2, 2024
14 checks passed
@Garzas Garzas deleted the fix/conversation-options-divider branch April 2, 2024 07:22
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@borichellow borichellow Awaiting requested review from borichellow

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @alexandreferris @saleniuk