-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable sound and vibration for notification reply [WPB-4741] #2841
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2841 +/- ##
===========================================
- Coverage 43.73% 43.72% -0.01%
===========================================
Files 422 422
Lines 14086 14088 +2
Branches 2544 2544
===========================================
Hits 6160 6160
- Misses 7203 7205 +2
Partials 723 723
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3872 succeeded. The build produced the following APK's: |
app/src/main/kotlin/com/wire/android/notification/MessageNotificationManager.kt
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3879 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3886 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When updating notification after reply app uses same notification channel as for normal messages
Causes (Optional)
User after reply receives self notification with vibration or sound
Solutions
Create special self messages channel to disable sound, vibration and lights