Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable sound and vibration for notification reply [WPB-4741] #2841

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 29, 2024

BugWPB-4741 Applause -[Android] Chat - Reply in a notification makes the own phone ringing/vibrating


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When updating notification after reply app uses same notification channel as for normal messages

Causes (Optional)

User after reply receives self notification with vibration or sound

Solutions

Create special self messages channel to disable sound, vibration and lights

@Garzas Garzas requested review from borichellow and saleniuk March 29, 2024 15:17
@Garzas Garzas self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.72%. Comparing base (f24c968) to head (c2c8950).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2841      +/-   ##
===========================================
- Coverage    43.73%   43.72%   -0.01%     
===========================================
  Files          422      422              
  Lines        14086    14088       +2     
  Branches      2544     2544              
===========================================
  Hits          6160     6160              
- Misses        7203     7205       +2     
  Partials       723      723              
Files Coverage Δ
...wire/android/notification/NotificationConstants.kt 46.66% <ø> (ø)
...android/notification/MessageNotificationManager.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24c968...c2c8950. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

Test Results

878 tests  ±0   878 ✅ ±0   13m 29s ⏱️ + 5m 44s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit c2c8950. ± Comparison against base commit f24c968.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3872 succeeded.

The build produced the following APK's:

@Garzas Garzas requested a review from saleniuk March 29, 2024 16:34
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3879 failed.

@Garzas Garzas requested a review from alexandreferris April 2, 2024 07:04
Copy link
Contributor

github-actions bot commented Apr 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas added this pull request to the merge queue Apr 2, 2024
@AndroidBob
Copy link
Collaborator

Build 3886 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit e3ed13b Apr 2, 2024
14 checks passed
@Garzas Garzas deleted the fix/self-notification-vibration branch April 2, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants