Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add avs and cc version to debug screen #2848

Merged

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/debug/DebugDataOptions.kt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add avs and cc version to debug screen

Solutions

Implement a gradle task that will read the lib.version.toml file and parse it to extract the dependencies version, the task is fixable and can be easily extended to include more dependencies but for now it is only AVS and CC

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Test Results

880 tests  ±0   880 ✅ ±0   10m 51s ⏱️ - 2m 58s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 56e81a7. ± Comparison against base commit 2f9e6de.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3915 failed.

@AndroidBob
Copy link
Collaborator Author

Build 4043 failed.

@AndroidBob
Copy link
Collaborator Author

Build 4045 failed.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara enabled auto-merge April 8, 2024 10:57
@AndroidBob
Copy link
Collaborator Author

Build 4046 failed.

@MohamadJaara MohamadJaara added this pull request to the merge queue Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 80d5aab Apr 8, 2024
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the feat/add-avs-and-cc-version-to-debug-screen-cherry-pick branch April 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants