-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: read conversation on short list [WPB-7432] #2877
fix: read conversation on short list [WPB-7432] #2877
Conversation
Test Results888 tests 888 ✅ 8m 29s ⏱️ Results for commit 50e096f. ♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4076 failed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2877 +/- ##
===========================================
- Coverage 43.80% 43.75% -0.05%
===========================================
Files 424 432 +8
Lines 14066 14167 +101
Branches 2501 2455 -46
===========================================
+ Hits 6161 6199 +38
- Misses 7187 7276 +89
+ Partials 718 692 -26
... and 106 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4094 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
5930c69
to
f1f35b9
Compare
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4137 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When list was not scrollable and new message appears being in Conversation Screen conversation was not marked as read
Solutions
Add additional condition to check if list is not scrollable to mark conversation as read when new message appears