Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read conversation on short list [WPB-7432] #2877

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 9, 2024

BugWPB-7432 [Android] Message not marked as read when received in empty conversation when screen is open

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When list was not scrollable and new message appears being in Conversation Screen conversation was not marked as read

Solutions

Add additional condition to check if list is not scrollable to mark conversation as read when new message appears

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Test Results

888 tests   888 ✅  8m 29s ⏱️
122 suites    0 💤
122 files      0 ❌

Results for commit 50e096f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4076 failed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.75%. Comparing base (2d77b2f) to head (50e096f).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2877      +/-   ##
===========================================
- Coverage    43.80%   43.75%   -0.05%     
===========================================
  Files          424      432       +8     
  Lines        14066    14167     +101     
  Branches      2501     2455      -46     
===========================================
+ Hits          6161     6199      +38     
- Misses        7187     7276      +89     
+ Partials       718      692      -26     
Files Coverage Δ
...ndroid/ui/home/conversations/AuthorHeaderHelper.kt 94.73% <ø> (ø)

... and 106 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b700e...50e096f. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 4094 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas force-pushed the fix/read-conversation-on-short-list-cherry-pick branch from 5930c69 to f1f35b9 Compare April 12, 2024 07:05
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas enabled auto-merge April 12, 2024 07:38
@Garzas Garzas added this pull request to the merge queue Apr 12, 2024
@AndroidBob
Copy link
Collaborator Author

Build 4137 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 043add3 Apr 12, 2024
12 checks passed
@Garzas Garzas deleted the fix/read-conversation-on-short-list-cherry-pick branch April 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants