Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Display verified E2EI icon other user devices list [WPB-6974] #2879

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix: Display verified E2EI icon other user devices list [WPB-6974] #2879

merged 3 commits into from
Apr 25, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Apr 9, 2024 •
edited by github-actions bot
Loading

BugWPB-6974 [Android] No green shield visible on devices list from other users

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:
kalium

What's new in this PR?

Issues

No green shield visible on devices list from other users

Causes (Optional)

Compose flag in DeviceItem element was set into

Solutions

update that flag

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Apr 9, 2024
@github-actions github-actions bot assigned AndroidBob and unassigned borichellow Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024 •
edited
Loading

Test Results

909 tests  ±0   909 ✅ ±0   17m 23s ⏱️ + 5m 32s
123 suites ±0     0 💤 ±0 
123 files   ±0     0 ❌ ±0 

Results for commit 718575d. ± Comparison against base commit ecb1140.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 4088 failed.

@yamilmedina yamilmedina requested review from a team, yamilmedina, mchenani, Garzas, ohassine and saleniuk and removed request for a team April 25, 2024 13:58
@yamilmedina yamilmedina enabled auto-merge April 25, 2024 14:02
@yamilmedina yamilmedina disabled auto-merge April 25, 2024 14:35
@yamilmedina yamilmedina enabled auto-merge April 25, 2024 14:35
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Apr 25, 2024
@AndroidBob
Copy link
Collaborator Author

Build 4462 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 7e463b0 Apr 25, 2024
12 checks passed
@yamilmedina yamilmedina deleted the fix/display_verified_e2ei_icon_other_user_devices_list-cherry-pick branch April 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@borichellow borichellow

@AndroidBob AndroidBob

Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndroidBob @yamilmedina @MohamadJaara @vitorhugods @saleniuk @borichellow