Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong color of fdroid app icon (WPB-7287) #2886

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

e-lisa
Copy link
Contributor

@e-lisa e-lisa commented Apr 11, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@e-lisa e-lisa changed the title WPB-7287 - Fixed conditional resource inclusion Fixed conditional resource inclusion (WPB-7287) Apr 11, 2024
@e-lisa e-lisa changed the title Fixed conditional resource inclusion (WPB-7287) fix: wrong color of fdroid app icon (WPB-7287) Apr 11, 2024
@MohamadJaara
Copy link
Member

@e-lisa the semantic commit message action is failing because this PR has only one commit and it's not semantic you can fix this by editing the commit message for that commit or pushing an empty commit so the PR title can be used

@MohamadJaara MohamadJaara merged commit 480a5a6 into wireapp:release/candidate Apr 12, 2024
9 of 12 checks passed
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

MohamadJaara pushed a commit that referenced this pull request Apr 18, 2024
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>

(cherry picked from commit 480a5a6)
MohamadJaara pushed a commit that referenced this pull request Apr 18, 2024
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>

(cherry picked from commit 480a5a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants