-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error in deciding whether the current build should use open source only dependencies or not #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build 4207 failed. |
Signed-off-by: MohamadJaara <mohamad.jaara@wire.com>
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4214 succeeded. The build produced the following APK's: |
MohamadJaara
approved these changes
Apr 16, 2024
vitorhugods
approved these changes
Apr 16, 2024
APKs built during tests are available here. Scroll down to Artifacts! |
Build 4302 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
app/build.gradle.kts
kalium
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Causes (Optional)
error in deciding whether the current build should use open source only dependencies or not was only checking if the gradle task it is currently running include the word fdroid or not e.g.
./gradlew :appCompileFdroidCompatReleaseSources
this will work fine in most cases but not megazord, megazord tuns a shortened version of the task./gradlew compileApp
and append the build flavor and type form environment variablesSolutions
check the current build flavor from the environment variables first and then check the current gradle task
Needs releases with:
Testing
manually tested with both fdroid and prod flavors on megazord ans it is all good
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.