Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow swipe to reply (WPB-982) 🍒 #2959

Merged
merged 1 commit into from
May 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2024

StoryWPB-982 Swipe right to reply to a message

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Self explanatory, innit?

Solutions

Use SwipeToDismissBoxState.

  • Always reject state changes, so after the drag animation it goes back to settled.

Extracted the whole drag animation logic and icon setup into SwipableToReplyBox. It can be modified to allow swiping to multiple directions with different actions later on.

Testing

Not really testable at the moment. It's all UI.

Attachments

Light and Dark theme usage

Swipe.to.Reply.mp4

Back gesture support

Edge.margin.mp4

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 4562 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods force-pushed the feat/allow-swipe-to-reply-cherry-pick branch from ed8fdcb to d59d01d Compare May 3, 2024 11:42
@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 3, 2024
@vitorhugods vitorhugods merged commit 0c82442 into develop May 3, 2024
7 of 8 checks passed
@vitorhugods vitorhugods deleted the feat/allow-swipe-to-reply-cherry-pick branch May 3, 2024 11:43
Copy link
Contributor Author

github-actions bot commented May 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants