Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call dropped when turning camera on (WPB-9013) #2974

Merged
merged 3 commits into from
May 6, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 6, 2024

BugWPB-9013 [Android] No audio received/sent until i minize and maximize the call


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • No audio received/sent until i minimise and maximize the call
  • Remote can see my video only after minimising and maximising the call
  • I can see remote videos only after minimising and maximising the call

Causes (Optional)

When the user tries to turn the camera on, the call drops and this is because we are calling wcall_set_video_send_state() twice:
The Lifecycle Event Observer does not trigger when we lifecycle state is changed, but only trigger when the camera is changed or callStatus is changed

Solutions

Move LifecycleEventObserver part to the parent composable

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, MohamadJaara, vitorhugods, Garzas and saleniuk and removed request for a team May 6, 2024 11:34
Copy link
Contributor

github-actions bot commented May 6, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1000bd7.

@ohassine ohassine enabled auto-merge (squash) May 6, 2024 12:12
@ohassine ohassine merged commit 2c3d789 into release/candidate May 6, 2024
10 of 11 checks passed
@ohassine ohassine deleted the call-drop-when-turning-camera-on branch May 6, 2024 12:17
Copy link
Contributor

github-actions bot commented May 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 4621 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants