Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enabling QR codes for users (WPB-12115) #3616

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 8, 2024

TaskWPB-12115 [Android] : QR code opens up deeplinks which links directly to the app rather than going to the web


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Previously we had to disable the QR code feature, to assess some last moment requirements. #3569
Now everything is sorted out, definitions done, so we need to modify the code and re-enable.

Solutions

This PR:

  • Enables QR code by feature flag
  • Implement deeplink according to new specs (direct deeplink, instead of accounts)
  • Handles the same error dialog for other user profiles, as in iOS and Web

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 8, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.34%. Comparing base (e8b5148) to head (fd75a42).

Files with missing lines Patch % Lines
...erprofile/other/OtherUserProfileScreenViewModel.kt 0.00% 6 Missing ⚠️
...roid/ui/userprofile/other/OtherUserProfileState.kt 50.00% 2 Missing ⚠️
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3616   +/-   ##
==================================================
  Coverage              45.33%   45.34%           
==================================================
  Files                    471      471           
  Lines                  15835    15845   +10     
  Branches                2654     2655    +1     
==================================================
+ Hits                    7179     7185    +6     
- Misses                  7885     7887    +2     
- Partials                 771      773    +2     
Files with missing lines Coverage Δ
.../wire/android/ui/userprofile/qr/SelfQRCodeState.kt 100.00% <100.00%> (ø)
...e/android/ui/userprofile/qr/SelfQRCodeViewModel.kt 50.00% <100.00%> (+1.35%) ⬆️
.../wire/android/util/debug/FeatureVisibilityFlags.kt 0.00% <ø> (ø)
...roid/ui/userprofile/other/OtherUserProfileState.kt 74.00% <50.00%> (-2.60%) ⬇️
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 76.33% <33.33%> (+1.72%) ⬆️
...erprofile/other/OtherUserProfileScreenViewModel.kt 58.58% <0.00%> (-1.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b5148...fd75a42. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3616.apk is available for download

@yamilmedina yamilmedina requested a review from ohassine November 11, 2024 08:51
Copy link
Contributor

Built wire-android-staging-compat-pr-3616.apk is available for download

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3616.apk is available for download

@yamilmedina yamilmedina added l10n and removed l10n labels Nov 12, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Nov 12, 2024
Merged via the queue into release/candidate with commit 84c2755 Nov 12, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/finalize-qr-m1 branch November 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants