Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conversation favorites [WPB-11637] #3634

Merged
merged 15 commits into from
Nov 15, 2024
Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 14, 2024

StoryWPB-11637 [Android] User Story for filters in the Top Bar


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implemented favorite folder with conversations handling changes from other clients

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

favorites_handling.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@Garzas Garzas self-assigned this Nov 14, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.99%. Comparing base (5972c94) to head (db7f1db).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...tions/usecase/GetConversationsFromSearchUseCase.kt 71.42% 4 Missing and 2 partials ⚠️
...ome/conversationslist/ConversationListViewModel.kt 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3634      +/-   ##
===========================================
+ Coverage    45.97%   45.99%   +0.01%     
===========================================
  Files          473      473              
  Lines        16066    16074       +8     
  Branches      2659     2662       +3     
===========================================
+ Hits          7387     7393       +6     
+ Misses        7900     7899       -1     
- Partials       779      782       +3     
Files with missing lines Coverage Δ
...ome/conversationslist/ConversationListViewModel.kt 32.62% <50.00%> (-0.57%) ⬇️
...tions/usecase/GetConversationsFromSearchUseCase.kt 72.97% <71.42%> (-13.24%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5972c94...db7f1db. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3634.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3634.apk is available for download

wireSessionImageLoader,
userTypeMapper,
dispatcherProvider
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: could you write a test to make sure that when we call this use case with ConversationFilter.FAVORITES then we get only favorited conversations or at least that we call GetFavoriteFolderUseCase and ObserveConversationsFromFolderUseCase instead of GetPaginatedFlowOfConversationDetailsWithEventsBySearchQueryUseCase? 😄

@Garzas Garzas enabled auto-merge November 15, 2024 13:01
@Garzas Garzas added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit 91578c9 Nov 15, 2024
12 of 13 checks passed
@Garzas Garzas deleted the feat/conversation-favorites branch November 15, 2024 14:13
Copy link
Contributor

Built wire-android-staging-compat-pr-3634.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3634.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants