-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conversation favorites [WPB-11637] #3634
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3634 +/- ##
===========================================
+ Coverage 45.97% 45.99% +0.01%
===========================================
Files 473 473
Lines 16066 16074 +8
Branches 2659 2662 +3
===========================================
+ Hits 7387 7393 +6
+ Misses 7900 7899 -1
- Partials 779 782 +3
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3634.apk is available for download |
Built wire-android-dev-debug-pr-3634.apk is available for download |
wireSessionImageLoader, | ||
userTypeMapper, | ||
dispatcherProvider | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could you write a test to make sure that when we call this use case with ConversationFilter.FAVORITES
then we get only favorited conversations or at least that we call GetFavoriteFolderUseCase
and ObserveConversationsFromFolderUseCase
instead of GetPaginatedFlowOfConversationDetailsWithEventsBySearchQueryUseCase
? 😄
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3634.apk is available for download |
Built wire-android-dev-debug-pr-3634.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Implemented favorite folder with conversations handling changes from other clients
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
favorites_handling.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.