Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: conference simulcast support (WPB-11480) #3638

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 15, 2024

StoryWPB-11480 [Android] Simulcast Support & Automatic Quality Adjustments


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On AVS 10.x.x, we have finally supported for simulcast (multiple quality for participants video). This is an improvement in the overall experience, and as well in performance, because when the client is with a Tile in Full Screen, we can request only that video stream, saving bandwidth.

Solutions

  • Introduce current SelectedParticipant in VM to filter which needs HIGH Quality
  • Request video streams in FullScreen Tile, by doing so, we only request video stream for that participant.
  • Improve logging with TAGs for ViewModel.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

As of now, it is not possible, but when SFT version 5 is deployed on staging, it will be possible.
For development purposes, was 'hacked' using the SFT test server and local webapp.

Attachments (Optional)

https://drive.google.com/file/d/18N0W4hXT3MDfL_tsD0_rJCzgDz5s4D9D/view?usp=sharing


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (8a30ee1) to head (e479b9f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...android/ui/calling/ongoing/OngoingCallViewModel.kt 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3638      +/-   ##
===========================================
+ Coverage    45.94%   46.00%   +0.05%     
===========================================
  Files          472      472              
  Lines        16083    16093      +10     
  Branches      2663     2664       +1     
===========================================
+ Hits          7390     7403      +13     
+ Misses        7920     7917       -3     
  Partials       773      773              
Files with missing lines Coverage Δ
...id/ui/calling/ongoing/fullscreen/FullScreenTile.kt 0.00% <ø> (ø)
.../calling/ongoing/fullscreen/SelectedParticipant.kt 100.00% <100.00%> (+100.00%) ⬆️
...android/ui/calling/ongoing/OngoingCallViewModel.kt 76.31% <90.90%> (+3.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a30ee1...e479b9f. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3638.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3638.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3638.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3638.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Nov 20, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3638.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3638.apk is available for download

Merged via the queue into develop with commit 7cd4bd6 Nov 20, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/conference-simulcast-support branch November 20, 2024 13:23
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 20, 2024
yamilmedina added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants