Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upload mapping file to s3 (WPB-8774) #3713

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

chore: upload mapping file to s3 (WPB-8774) #3713

wants to merge 31 commits into from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 5, 2024 •
edited by github-actions bot
Loading

TaskWPB-8774 [Android] implement easy to access archive of mapping files for debugging

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Upload mapping file with the APK to S3 for non Debug builds

Screenshot 2024-12-13 at 09 48 43

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.80%. Comparing base (f45ed9e) to head (a9a8ed5).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3713   +/-   ##
========================================
  Coverage    45.80%   45.80%           
========================================
  Files          483      483           
  Lines        16513    16513           
  Branches      2783     2783           
========================================
  Hits          7563     7563           
  Misses        8170     8170           
  Partials       780      780

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45ed9e...a9a8ed5. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@ohassine ohassine removed WIP Work In Progress DO NOT MERGE labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@ohassine ohassine changed the title CI: upload mapping file to s3 (WPB-8774) chore: upload mapping file to s3 (WPB-8774) Dec 13, 2024
@ohassine ohassine requested review from a team, typfel, yamilmedina, MohamadJaara, Garzas and damian-kaczmarek and removed request for a team December 13, 2024 08:40
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Built wire-android-staging-compat-pr-3713.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Built wire-android-staging-compat-pr-3713.apk is available for download

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Built wire-android-staging-compat-pr-3713.apk is available for download

yamilmedina
yamilmedina reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job 👏
Just added a small change we need in order for the upload to work, since the S3 bucket now only allows private uploads

.github/actions/deploy-to-s3/action.yml
Comment on lines +106 to +107
output-file-url: 'true'
public: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output-file-url: 'true'
public: true
output-file-url: 'false'
public: false

.github/actions/deploy-to-s3/action.yml
Comment on lines +119 to +120
output-file-url: 'true'
public: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output-file-url: 'true'
public: true
output-file-url: 'false'
public: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina left review comments

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@damian-kaczmarek damian-kaczmarek Awaiting requested review from damian-kaczmarek damian-kaczmarek was automatically assigned from wireapp/android

At least 2 approving reviews are required to merge this pull request.

Assignees

@ohassine ohassine

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohassine @codecov-commenter @yamilmedina