Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message context menu (WEBAPP-2861) #10

Merged
merged 1 commit into from
Aug 15, 2016
Merged

message context menu (WEBAPP-2861) #10

merged 1 commit into from
Aug 15, 2016

Conversation

herrmannplatz
Copy link
Contributor

@herrmannplatz herrmannplatz commented Aug 15, 2016 •
edited
Loading

This PR adds a custom context module, which stops and any propagation of the 'customContextMenu' Event and replaces the web context menu with a native menu. This should replace the current conversation list menu in the near future.

@herrmannplatz herrmannplatz force-pushed the feature/message-context-menu-WEBAPP-2861 branch from 8b26904 to 9fbbeb0 Compare August 15, 2016 14:32
lipis
lipis reviewed Aug 15, 2016
View reviewed changes
electron/js/menu/context.js
@@ -134,6 +135,12 @@ window.addEventListener('click', function(e) {
}
}, true);

window.addEventListener('customContextMenu', function(e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use event instead of e?

@herrmannplatz herrmannplatz force-pushed the feature/message-context-menu-WEBAPP-2861 branch from 2456824 to 5aea57b Compare August 15, 2016 15:12
lipis
lipis reviewed Aug 15, 2016
View reviewed changes
electron/js/menu/context.js
@@ -134,6 +135,12 @@ window.addEventListener('click', function(e) {
}
}, true);

window.addEventListener(z.components.ContextMenuEvent.CONTEXT_MENU, function(e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e --> event :)

@herrmannplatz herrmannplatz force-pushed the feature/message-context-menu-WEBAPP-2861 branch from 8b54d38 to 84a16c8 Compare August 15, 2016 15:20
lipis
lipis reviewed Aug 15, 2016
View reviewed changes
electron/js/menu/context.js
e.preventDefault();
image_menu.image = element.src;
event.preventDefault();
image_menu.image = element.src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; (saw it on travis :)

@herrmannplatz herrmannplatz force-pushed the feature/message-context-menu-WEBAPP-2861 branch from 1e4a37b to ee64182 Compare August 15, 2016 15:30
@herrmannplatz herrmannplatz merged commit 8cb1486 into master Aug 15, 2016
@herrmannplatz herrmannplatz deleted the feature/message-context-menu-WEBAPP-2861 branch August 15, 2016 15:34
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 19, 2018
Closed
lipis pushed a commit that referenced this pull request Oct 1, 2018
@dependabot @lipis
build(deps-dev): bump eslint from 5.6.0 to 5.6.1 (#1771)
38c7bca 
Bumps [eslint](https://github.com/eslint/eslint) from 5.6.0 to 5.6.1.
<details>
<summary>Release notes</summary>

*Sourced from [eslint's releases](https://github.com/eslint/eslint/releases).*

> ## v5.6.1
> * 9b26bdb Fix: avoid exponential require-atomic-updates traversal (fixes [#10893](https://github-redirect.dependabot.com/eslint/eslint/issues/10893)) ([#10894](https://github-redirect.dependabot.com/eslint/eslint/issues/10894)) (Teddy Katz)
> * 9432b10 Fix: make separateRequires work in consecutive mode (fixes [#10784](https://github-redirect.dependabot.com/eslint/eslint/issues/10784)) ([#10886](https://github-redirect.dependabot.com/eslint/eslint/issues/10886)) (Pig Fang)
> * e51868d Upgrade: debug@4 (fixes [#10854](https://github-redirect.dependabot.com/eslint/eslint/issues/10854)) ([#10887](https://github-redirect.dependabot.com/eslint/eslint/issues/10887)) (薛定谔的猫)
> * d3f3994 Docs: add information about reporting security issues ([#10889](https://github-redirect.dependabot.com/eslint/eslint/issues/10889)) (Teddy Katz)
> * cc458f4 Build: fix failing tests on master ([#10890](https://github-redirect.dependabot.com/eslint/eslint/issues/10890)) (Teddy Katz)
> * a6ebfd3 Docs: clarify defaultAssignment option, fix no-unneeded-ternary examples ([#10874](https://github-redirect.dependabot.com/eslint/eslint/issues/10874)) (CoffeeTableEspresso)
> * 9d52541 Fix: Remove duplicate error message on crash (fixes [#8964](https://github-redirect.dependabot.com/eslint/eslint/issues/8964)) ([#10865](https://github-redirect.dependabot.com/eslint/eslint/issues/10865)) (Nicholas C. Zakas)
> * 4eb9a49 Docs: Update quotes.md ([#10862](https://github-redirect.dependabot.com/eslint/eslint/issues/10862)) (The Jared Wilcurt)
> * 9159e9b Docs: Update complexity.md ([#10867](https://github-redirect.dependabot.com/eslint/eslint/issues/10867)) (Szymon Przybylski)
> * 14f4e46 Docs: Use Linter instead of linter in Nodejs API page ([#10864](https://github-redirect.dependabot.com/eslint/eslint/issues/10864)) (Nicholas C. Zakas)
> * b3e3cb1 Chore: Update debug log name to match filename ([#10863](https://github-redirect.dependabot.com/eslint/eslint/issues/10863)) (Nicholas C. Zakas)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [eslint's changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md).*

> v5.6.1 - September 28, 2018
> 
> * 9b26bdb Fix: avoid exponential require-atomic-updates traversal (fixes [#10893](https://github-redirect.dependabot.com/eslint/eslint/issues/10893)) ([#10894](https://github-redirect.dependabot.com/eslint/eslint/issues/10894)) (Teddy Katz)
> * 9432b10 Fix: make separateRequires work in consecutive mode (fixes [#10784](https://github-redirect.dependabot.com/eslint/eslint/issues/10784)) ([#10886](https://github-redirect.dependabot.com/eslint/eslint/issues/10886)) (Pig Fang)
> * e51868d Upgrade: debug@4 (fixes [#10854](https://github-redirect.dependabot.com/eslint/eslint/issues/10854)) ([#10887](https://github-redirect.dependabot.com/eslint/eslint/issues/10887)) (薛定谔的猫)
> * d3f3994 Docs: add information about reporting security issues ([#10889](https://github-redirect.dependabot.com/eslint/eslint/issues/10889)) (Teddy Katz)
> * cc458f4 Build: fix failing tests on master ([#10890](https://github-redirect.dependabot.com/eslint/eslint/issues/10890)) (Teddy Katz)
> * a6ebfd3 Docs: clarify defaultAssignment option, fix no-unneeded-ternary examples ([#10874](https://github-redirect.dependabot.com/eslint/eslint/issues/10874)) (CoffeeTableEspresso)
> * 9d52541 Fix: Remove duplicate error message on crash (fixes [#8964](https://github-redirect.dependabot.com/eslint/eslint/issues/8964)) ([#10865](https://github-redirect.dependabot.com/eslint/eslint/issues/10865)) (Nicholas C. Zakas)
> * 4eb9a49 Docs: Update quotes.md ([#10862](https://github-redirect.dependabot.com/eslint/eslint/issues/10862)) (The Jared Wilcurt)
> * 9159e9b Docs: Update complexity.md ([#10867](https://github-redirect.dependabot.com/eslint/eslint/issues/10867)) (Szymon Przybylski)
> * 14f4e46 Docs: Use Linter instead of linter in Nodejs API page ([#10864](https://github-redirect.dependabot.com/eslint/eslint/issues/10864)) (Nicholas C. Zakas)
> * b3e3cb1 Chore: Update debug log name to match filename ([#10863](https://github-redirect.dependabot.com/eslint/eslint/issues/10863)) (Nicholas C. Zakas)
</details>
<details>
<summary>Commits</summary>

- [`bf96e96`](eslint/eslint@bf96e96) 5.6.1
- [`7e13c4c`](eslint/eslint@7e13c4c) Build: changelog update for 5.6.1
- [`9b26bdb`](eslint/eslint@9b26bdb) Fix: avoid exponential require-atomic-updates traversal (fixes [#10893](https://github-redirect.dependabot.com/eslint/eslint/issues/10893)) ([#10894](https://github-redirect.dependabot.com/eslint/eslint/issues/10894))
- [`9432b10`](eslint/eslint@9432b10) Fix: make separateRequires work in consecutive mode (fixes [#10784](https://github-redirect.dependabot.com/eslint/eslint/issues/10784)) ([#10886](https://github-redirect.dependabot.com/eslint/eslint/issues/10886))
- [`e51868d`](eslint/eslint@e51868d) Upgrade: debug@4 (fixes [#10854](https://github-redirect.dependabot.com/eslint/eslint/issues/10854)) ([#10887](https://github-redirect.dependabot.com/eslint/eslint/issues/10887))
- [`d3f3994`](eslint/eslint@d3f3994) Docs: add information about reporting security issues ([#10889](https://github-redirect.dependabot.com/eslint/eslint/issues/10889))
- [`cc458f4`](eslint/eslint@cc458f4) Build: fix failing tests on master ([#10890](https://github-redirect.dependabot.com/eslint/eslint/issues/10890))
- [`a6ebfd3`](eslint/eslint@a6ebfd3) Docs: clarify defaultAssignment option, fix no-unneeded-ternary examples ([#10](https://github-redirect.dependabot.com/eslint/eslint/issues/10)...
- [`9d52541`](eslint/eslint@9d52541) Fix: Remove duplicate error message on crash (fixes [#8964](https://github-redirect.dependabot.com/eslint/eslint/issues/8964)) ([#10865](https://github-redirect.dependabot.com/eslint/eslint/issues/10865))
- [`4eb9a49`](eslint/eslint@4eb9a49) Docs: Update quotes.md ([#10862](https://github-redirect.dependabot.com/eslint/eslint/issues/10862))
- Additional commits viewable in [compare view](eslint/eslint@v5.6.0...v5.6.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=5.6.0&new-version=5.6.1)](https://dependabot.com/compatibility-score.html?dependency-name=eslint&package-manager=npm_and_yarn&previous-version=5.6.0&new-version=5.6.1)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herrmannplatz @lipis