feat: context menu for accounts (WEBAPP-4382) #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yserz
approved these changes
Oct 17, 2017
Yserz
reviewed
Oct 17, 2017
| accountContextPosition: { x: 0, y: 0 }, | ||
| isAccountContextMenuVisible: false, | ||
| const defaultState = { | ||
| accountId: 0, |
There was a problem hiding this comment.
Default values for IDs should be strings
Yserz
reviewed
Oct 17, 2017
| isAtLeastAdmin: false, | ||
| isEditAccountMenuVisible: false, | ||
| position: { x: 0, y: 0 }, | ||
| sessionId: 0, |
There was a problem hiding this comment.
Default values for IDs should be strings
AndyLnd
changed the title
gregor
approved these changes
Oct 17, 2017
electron/locale/strings-de.js
Outdated
| @@ -71,5 +69,8 @@ string.unreadMessages = 'Ungelesene Nachrichten'; | |||
|
|
|||
| string.wrapperAddAccount = 'Konto hinzufügen'; | |||
| string.wrapperCreateTeam = 'Team erstellen'; | |||
| string.wrapperLogOut = 'Ausloggen'; | |||
There was a problem hiding this comment.
We use Abmelden everywhere else. Fixed on Crowdin. Please pull again.
lipis
approved these changes
Oct 17, 2017
lipis
reviewed
Oct 17, 2017
electron/js/preload.js
Outdated
| @@ -17,8 +17,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
|
|
|||
| const {ipcRenderer, webFrame} = require('electron'); | |||
| const { ipcRenderer, webFrame } = require('electron'); | |||
lipis
reviewed
Oct 17, 2017
electron/js/preload.js
Outdated
| @@ -28,6 +27,7 @@ window.locStrings = locale[locale.getCurrent()]; | |||
| window.locStringsDefault = locale['en']; | |||
|
|
|||
| const getSelectedWebview = () => document.querySelector('.Webview:not(.hide)'); | |||
| const getWebviewById = id => document.querySelector('.Webview[data-accountid="' + id + '"]'); | |||
There was a problem hiding this comment.
`.Webview[data-accountid="${id}"]`
|
Fixes #872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.