Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call electron-builder directly from Gruntfile (w/ native rebuild) #248

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Call electron-builder directly from Gruntfile (w/ native rebuild) #248

merged 2 commits into from
Dec 5, 2016

Conversation

ConorIA
Copy link
Contributor

@ConorIA ConorIA commented Dec 4, 2016

[conor@Sushi wire-desktop]$ yarn --version
0.18.0
[conor@Sushi wire-desktop]$ yarn
yarn install v0.18.0
$ cd electron && yarn
yarn install v0.18.0
[1/4] Resolving packages...
success Already up-to-date.
Done in 0.90s.
[1/4] Resolving packages...
success Already up-to-date.
$ yarn run rebuild-native-modules
yarn run v0.18.0
$ electron-rebuild -m ./electron/node_modules -f 
Couldn't find electron-prebuilt and no --node-module-version parameter set, always rebuilding
Done in 32.12s.
Done in 35.02s.
[conor@Sushi wire-desktop]$ node_modules/.bin/build --linux --x64 --dir
Rebuilding native production dependencies for arch x64
Packaging for linux x64 using electron 1.4.10 to wrap/dist/linux-unpacked
[conor@Sushi wire-desktop]$ node_modules/.bin/build --linux --ia32 --dir
Rebuilding native production dependencies for arch ia32
Packaging for linux ia32 using electron 1.4.10 to wrap/dist/linux-ia32-unpacked
Downloading tmp-9090-0-electron-v1.4.10-linux-ia32.zip
[============================================>] 100.0% of 44.53 MB (1.84 MB/s)

@lipis
Copy link
Contributor

lipis commented Dec 4, 2016

had to check the history about it.. found it #148 :)

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 4, 2016

Strangely enough, I am still getting an error when I run the grunt task. It only works when I explicitly build with node_modules/.bin/build

@lipis
Copy link
Contributor

lipis commented Dec 4, 2016

clean install everything? (git clean -fdx)

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 4, 2016

clean install everything? (git clean -fdx)

Just saw this. I will try reverting 0ff1be1 locally and see if it works.

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 4, 2016

No luck. But I'm thinking that maybe I was misjudging the situation...

The build command doesn't seem to be working when called with yarn run.
However, when called directly, it can build / rebuild without any issues.

@ConorIA ConorIA changed the title Rebuild now works with yarn >= 0.18.0 Call electron-builder directly from Gruntfile (w/ native rebuild) Dec 4, 2016
@lipis
Copy link
Contributor

lipis commented Dec 4, 2016

That's awesome! Thanks for spending more time..

@lipis lipis merged commit 5139171 into wireapp:master Dec 5, 2016
@lipis
Copy link
Contributor

lipis commented Dec 5, 2016

Had to reinstall my Ubuntu virtual machine.. and now I'm getting this error. Any clue @ConorIA?

Has nothing to do with the PR most likely.. but maybe I'm forgetting something to install?

latest Node 7.2.0, yarn 0.18.0

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 5, 2016

@lipis, I'm getting the same. Seems that electron-builder is expecting to find /usr/lib/libreadline.so.6, but the latest version is /usr/lib/libreadline.so.7.

I haven't tried it, but a simple ln -s /usr/lib/libreadline.so.7 /usr/lib/libreadline.so.6 might work.

UPDATE: Yep, sure enough, the symlink works.

@ConorIA ConorIA deleted the yarn branch December 5, 2016 19:22
@lipis
Copy link
Contributor

lipis commented Dec 6, 2016

had to install it actually sudo apt-get install libreadline6 and it worked.. thanks @ConorIA

@lipis
Copy link
Contributor

lipis commented Dec 6, 2016

Oups.. too fast.. :) It built the 64 versions.. but failed later :( https://gist.github.com/lipis/008b9c53a5f70b58331254d13786c519

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 6, 2016

Are you using g++-multilib? I'm not sure, but I'd say you're missing a ia32 library somewhere. I could build both the x64 and ia32 without issue yesterday.

@ConorIA
Copy link
Contributor Author

ConorIA commented Jan 18, 2017

Now that the build process is back to using NPM, this could probably be changed back to tasks in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants