fix: Handle umlaut in og:image (WEBAPP-4156) #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@herrmannplatz I think we should close this one.. right?! |
# Conflicts: # electron/js/lib/__mocks__/og.js # electron/js/lib/base64-image.js # electron/js/lib/datauri.js # electron/js/lib/download.js # electron/js/lib/googleAuth.js # electron/js/lib/openGraph.js
|
@lipis This is supposed to fix a fairly annoying bug. I will take a look and try to get this into a mergable shape. |
added 2 commits
October 10, 2017 19:58
gregor
force-pushed
the
bug/open-graph
branch
from
e92968e to
34525d8
Compare
gregor
force-pushed
the
bug/open-graph
branch
from
34525d8 to
4fd6bf3
Compare
gregor
changed the title
lipis
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.