Make the update.sh script take a _path_ instead of a _name_ #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means I can do: ./bin/update.sh charts/wire-se<TAB> and it auto-completes to the right chart name, which saves me 10 seconds per day and makes me not have to know a chart name apriori. I think the UX is a lot better, as we get free completion of what charts are available
jschaul
approved these changes
Sep 3, 2019
|
Are there any other scripts we use internally that depend on this script that might break because of this? |
I don't think so, I did a quick grep, didn't find anything. But actually I noticed in this repo |
|
@jschaul oould we look at that script together tomorrow? It's a bit daunting to me :) |
|
@arianvp please merge :) |
Merged
q3k
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Make the update.sh script take a _path_ instead of a _name_ This means I can do: ./bin/update.sh charts/wire-se<TAB> and it auto-completes to the right chart name, which saves me 10 seconds per day and makes me not have to know a chart name apriori. I think the UX is a lot better, as we get free completion of what charts are available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means I can do:
/bin/update.sh charts/wire-se<TAB>and it auto-completes to the rightchart name, which saves me 10 seconds per day and makes me not have to
know a chart name apriori. I think the UX is a lot better, as we get
free completion of what charts are available
Not a really important change, just something that made things a bit easier for me when working with these scripts interactively