Feature/deeplinks #155
Merged
Feature/deeplinks #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| websiteURL: "https://{{ prefix }}www.{{ domain }}" | ||
|
|
||
| # This currently assumes android clients only | ||
| blackListURL: "{{ assetsURL }}/public/blacklist/android.json" |
There was a problem hiding this comment.
Why not just use {{ assetsURL }}/public/blacklist and let clients add the suffix?
There was a problem hiding this comment.
I briefly looked into the code of android, and they seem to have "blacklistHost": "https://clientblacklist.wire.com/prod/android", i.e. the full path. If that changes, we can adapt this to be only a prefix.
Merged
q3k
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Create deeplink files upon minio installation * blacklisting * move static file logic to own role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ansible role creating files for deeplinking in custom envrironments. Also adds version blacklisting files.