Skip to content

Commit

Permalink
checking for 404 is flaky; depends on deletion succeeding
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisPenner committed Mar 19, 2019
1 parent ddd3e61 commit 359b5ae
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions services/spar/test-integration/Test/Spar/Scim/UserSpec.hs
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ specDeleteUser = do
!!! const 405 === statusCode

describe "DELETE /Users/:id" $ do
it "when called twice, should first delete then 404 you" $ do
it "should respond with 204" $ do
(tok, _) <- registerIdPAndScimToken
user <- randomScimUser
storedUser <- createUser tok user
Expand All @@ -528,8 +528,6 @@ specDeleteUser = do
spar <- view teSpar
deleteUser_ (Just tok) (Just uid) spar
!!! const 204 === statusCode
deleteUser_ (Just tok) (Just uid) spar
!!! const 404 === statusCode -- https://tools.ietf.org/html/rfc7644#section-3.6

-- FUTUREWORK: hscim has the the following test. we should probably go through all
-- `delete` tests and see if they can move to hscim or are already included there.
Expand Down

0 comments on commit 359b5ae

Please sign in to comment.