Skip to content

Commit

Permalink
Use fork of warp which closes connections gracefully (#3775)
Browse files Browse the repository at this point in the history
Upstream PR: yesodweb/wai#958
  • Loading branch information
akshaymankar authored Dec 13, 2023
1 parent 931df62 commit f795d50
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
3 changes: 3 additions & 0 deletions changelog.d/3-bug-fixes/warp-connection-close
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Ensure that HTTP 1.1 connections are grafully closed

To fix this warp had to be patched to fix the bug upstream: https://github.com/yesodweb/wai/pull/958
15 changes: 11 additions & 4 deletions nix/haskell-pins.nix
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,17 @@ let
sha256 = "sha256-xcGZ11ocdlB8ks20QAhtPZ+4ggmV4Om4CPHH/M6NjXk=";
};
};
# PR: https://github.com/yesodweb/wai/pull/958
warp = {
src = fetchgit {
url = "https://github.com/wireapp/wai";
rev = "bedd6a835f6d98128880465c30e8115fa986e3f6";
sha256 = "sha256-0r/d9YwcKZIZd10EhL2TP+W14Wjk0/S8Q4pVvZuZLaY=";
};
packages = {
"warp" = "warp";
};
};
};
hackagePins = {
# Major re-write upstream, we should get rid of this dependency rather than
Expand Down Expand Up @@ -292,10 +303,6 @@ let
version = "1.4.0";
sha256 = "sha256-zPT/FMxAiR94NReqNIDa/RS7dtiNWCRe3SZi8P11GDk=";
};
warp = {
version = "3.3.30";
sha256 = "sha256-VrK27a2wFtezh9qabcXGe2tw9EwBmI8mKwmpCtXq9rc=";
};
warp-tls = {
version = "3.4.3";
sha256 = "sha256-6MjlCKGC8v+7OiSuMFGwO8sgcA3gp0OfOnneI2wSpWI=";
Expand Down

0 comments on commit f795d50

Please sign in to comment.