ormolu.sh: make queries for options more robust #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are still ugly and we should try to find a better solution.
fisx
reviewed
Mar 9, 2020
There was a problem hiding this comment.
ah, i just realized that yq /= jq :) i don't have the former installed. can you add a test that emits a nice error message with a url if yq is not installed? currently the script keeps running, but not very smoothly.
otherwise i still think this is nice enough to ask developers to install it. what do others think?
mheinzel
force-pushed
the
mheinzel/nicer-ormolu-queries
branch
from
a918257 to
36fd5dc
Compare
fisx
approved these changes
Mar 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
yqwe don't rely on formatting and ordering of thepackage.yamlandpackage-default.yamlfiles anymore.I needed these changes to make the script work in
saml-web-sso, now I'm just backporting them.