Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index billing team members #1081

Merged
merged 28 commits into from
May 6, 2020

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Apr 28, 2020

@akshaymankar akshaymankar force-pushed the akshaymankar/index-billing-team-members branch from 43ea882 to c4a5cb5 Compare April 29, 2020 15:08
@akshaymankar akshaymankar marked this pull request as ready for review April 30, 2020 15:14
@akshaymankar akshaymankar changed the title [WIP] Index billing team members Index billing team members Apr 30, 2020
@akshaymankar
Copy link
Member Author

This PR is now reviewable, things which are still pending before this can be merged:

  • Make a tool to backfill data in production
  • Add the new flag to helm charts
  • Add the new flag to production config
  • Integrate the new tool with helm charts

@akshaymankar
Copy link
Member Author

When we call updateTeamMember we always have the previous permissions, right? Can we check that instead of always deleting?

I just asked the question about it. I will add it. I wasn't sure if there was any problem with that or not. For my education, can you please tell me if it is really bad in C* terms or is it just that we should reduce a query if we can?

@tiago-loureiro
Copy link
Contributor

tiago-loureiro commented May 4, 2020

I just asked the question about it. I will add it. I wasn't sure if there was any problem with that or not. For my education, can you please tell me if it is really bad in C* terms or is it just that we should reduce a query if we can?

I was mostly concerned about many tombstones but @jschaul concern about race condition is also a good point. Here's a contrived example of what I am thinking about: https://gist.github.com/tiago-loureiro/65db0c0fe8db66579609159ea1b97f86

Here's what I tried:

INSERT ... ('bla',0);
flush tables to disk
DELETE ... ('bla',0);
flush tables to disk
DELETE ... ('bla',0);
flush tables to disk

In there you can see that there was a row in the first sstable and now we have 3 sstables. Whenever we want to read the value, we need to go through all these records which can add up over time. The particular use case may not be as problematic but, if we can avoid it, then all the better. And I think that, in all our use cases, we don't even need an extra DB lookup, do we?

Copy link
Contributor

@tiago-loureiro tiago-loureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little sync with @fisx on the on the one issue would be good

@akshaymankar akshaymankar merged commit bc620c4 into develop May 6, 2020
@akshaymankar akshaymankar deleted the akshaymankar/index-billing-team-members branch May 6, 2020 10:16
@akshaymankar akshaymankar mentioned this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants