-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index billing team members #1081
Index billing team members #1081
Conversation
This will be useful when testing team events for promoted/demoted owners
43ea882
to
c4a5cb5
Compare
This PR is now reviewable, things which are still pending before this can be merged:
|
I just asked the question about it. I will add it. I wasn't sure if there was any problem with that or not. For my education, can you please tell me if it is really bad in C* terms or is it just that we should reduce a query if we can? |
I was mostly concerned about many tombstones but @jschaul concern about race condition is also a good point. Here's a contrived example of what I am thinking about: https://gist.github.com/tiago-loureiro/65db0c0fe8db66579609159ea1b97f86 Here's what I tried:
In there you can see that there was a row in the first sstable and now we have 3 sstables. Whenever we want to read the value, we need to go through all these records which can add up over time. The particular use case may not be as problematic but, if we can avoid it, then all the better. And I think that, in all our use cases, we don't even need an extra DB lookup, do we? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little sync with @fisx on the on the one issue would be good
Fixes https://github.com/zinfra/backend-issues/issues/1296