Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify signature on nginx tarballs #11

Merged
merged 2 commits into from
May 16, 2017
Merged

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented May 16, 2017

Fixes #10

@jschaul jschaul requested a review from twittner May 16, 2017 14:11
@@ -69,8 +69,11 @@ $(DIST):
BUNDLE=nginx-$(VERSION).tar.gz

src: $(TMPDIR)/$(BUNDLE)
#Find keys on https://nginx.org/en/pgp_keys.html
gpg --verify $(TMPDIR)/$(BUNDLE).asc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the signature is detached you also need to provide $(TMPDIR)/$(BUNDLE) as a second argument.

@jschaul
Copy link
Member Author

jschaul commented May 16, 2017

Since the signature is detached you also need to provide $(TMPDIR)/$(BUNDLE) as a second argument.

It seems my gpg is smart enough to figure that out by itself:

gpg --verify /tmp/nginx-1.12.0.tar.gz.asc
gpg: assuming signed data in `/tmp/nginx-1.12.0.tar.gz'

But I suppose giving a second argument makes that clearer and doesn't need any guessing on gpg's side. Updated Makefile.

@jschaul jschaul merged commit 8ee8901 into develop May 16, 2017
@jschaul jschaul deleted the feature/nginx-verify-download branch May 16, 2017 15:38
flokli pushed a commit that referenced this pull request Jul 1, 2020
* A module for filtering users

* Integrate filtering into the mock implementation

* Don't allow users with duplicate usernames

* Overhaul error handling; fix comments
smatting pushed a commit that referenced this pull request Apr 20, 2022
* diagrams

* planning: add diagram in HA-mode

* Add to understand/overview section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants