Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wire-api types in public endpoints (gundeck + cargohold) #1117

Merged
merged 2 commits into from
May 28, 2020
Merged

Use wire-api types in public endpoints (gundeck + cargohold) #1117

merged 2 commits into from
May 28, 2020

Conversation

mheinzel
Copy link
Contributor

This guarantees that the public API only depends on types defined in wire-api (and currently also types-common), so we can't break the public API by changing internal types.

@mheinzel mheinzel merged commit d13cb2f into develop May 28, 2020
@mheinzel mheinzel deleted the mheinzel/wire-api-in-public-endpoints-gundeck branch May 28, 2020 12:32
@akshaymankar akshaymankar mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mheinzel @fisx