Release 2020-06-10 #1135
Merged
Release 2020-06-10 #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
We don't have an automated check for this yet, so it was forgotten.
* Email validation for SAML auth. * Refactor; extend internal update-email end-point. * Roundtrip tests for FromByteString, ToByteString.
…ns) (#1130) * Do not depend on MonadFail for incomplete pattern handling. Co-authored-by: Matthias Heinzel <mheinzel@posteo.de>
…ature to stern/backoffice (#1129) * Simplify team feature database interface. There was one Data.* module per column in the team_features table. That may make sense at some point in the distant future, but as long as all those columns are just booleans, having one haskell module to access any of them in a uniform way saves a lot of boilerplate. * Use new feature flag types and make a generic end-point in stern. * Add FUTUREWORKs. Co-authored-by: Akshay Mankar <akshay@wire.com>
These are not enable by -Wall. More specifically:
-Wincomplete-uni-patterns
-Wincomplete-record-updates
-Wpartial-fields
In tests, I just disabled the warnings per file, but in production code,
I tried resolving the issues instead.
The only other warning I would consider adding is
-Wredundant-contraints, but it doesn't usually prevent bugs, so it's
probably not worth the time to add right now. It also flags usage of
`HasCallStack`, which can be annoying.
Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
fisx
commented
Jun 10, 2020
| - schema migration for cassandra_galley | ||
| - promote stern *after* galley | ||
| - promote spar *after* brig | ||
| - no need to upgrade nginz |
There was a problem hiding this comment.
I checked, and the sufficiently general routing pattern is here: https://github.com/zinfra/hegemony/blob/02656750fdecef2e410f7a30fb6254deb4518161/roles/nginz/vars/main.yml#L181
mheinzel
approved these changes
Jun 10, 2020
| - schema migration for cassandra_galley | ||
| - promote stern *after* galley | ||
| - promote spar *after* brig | ||
| - no need to upgrade nginz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Documentation
Internal changes