Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover and expose SFT servers in /calls/config/v2 #1177
Discover and expose SFT servers in /calls/config/v2 #1177
Changes from 1 commit
14b3692
189043f
27fc2e8
f9de188
07f848a
a345016
8a5f363
a0d7fe5
eaaa4f3
7101bd9
fb42bc3
1b5804d
b6c81ad
c00e688
a7820b5
6fcb23f
28d9971
05145d1
46df70e
1b1a85f
b51205f
a4e51da
f4d5282
3327d9f
c7a8150
bbe9458
096a8e5
271f648
42d6584
fde6771
009961d
b554390
7525503
7edee6a
959adfa
a48689c
7ec72b1
c4a6a9a
2f7c0fb
b5e26ae
939c802
2c3ef08
f54e611
4f0d7d2
b7b92d8
3929ea6
1f176f4
55cb7b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, the types here follow the RFC that describes SFT server lookup, or maybe something slightly more general, but more specific than DNS. Could we link that RFC here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC defines what SRV records are. The
dns
package interprets an SRV record into a tuple of 4 things, we named them here for it to be easier to comprehend across the code. Not sure if the mention is worth it. We mention the RFC in the ordering function because it might not be as obvious.