Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Invitations #1196

Merged
merged 5 commits into from
Aug 28, 2020
Merged

Refactor Invitations #1196

merged 5 commits into from
Aug 28, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Aug 27, 2020

tl;dr:

  • rename stuff that doesn't make sense and/or has no effects on behavior.
  • move stuff to make upcoming PRs smaller.

slightly more details:

  • drop irName, which carried the inviter name, but was never used.
  • fix test suite where we used irName wrong, and then ignored it.
  • give irEmail, irPhone, inIdentity, inPhone less ambiguous names.
  • shuffle record fields.
  • swagger.
  • move around validateHandle and some other helpers.

fisx added 5 commits August 27, 2020 12:28
@fisx
Cleanup data Invitation, InvitationRequest.
c3237f5 
- drop irName, which carried the inviter name, but was never used.
- fix test suite where we used irName wrong, and then ignored it.
- give irEmail, irPhone, inIdentity, inPhone less ambiguous names.
- shuffle record fields.
- swagger.
- move around validateHandle and some other helpers.
@fisx
Fix harmless bug.
e27d21f
@fisx
Remove confused TODO.
3f24e38
@fisx
Separate Id creation and DB effects better.
c06746e
@fisx
ormolu
6b6d151
@fisx
Copy link
Contributor Author

fisx commented Aug 28, 2020

all integration tests pass locally.

@fisx fisx merged commit 12e9492 into develop Aug 28, 2020
@fisx fisx deleted the fisx/scim-vs-saml-3 branch August 28, 2020 13:28
@tiago-loureiro tiago-loureiro mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisx @arianvp