Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit list of SFT servers to 5 (configurable), independent of the amount of servers … #1206

Merged
merged 7 commits into from
Sep 29, 2020
Merged

limit list of SFT servers to 5 (configurable), independent of the amount of servers … #1206

merged 7 commits into from
Sep 29, 2020

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Sep 16, 2020

…in the SRV record

Can be configured with

sft:
  sftListLength: 17 # an integer outside the range 1,100 will throw an error at startup time

akshaymankar
akshaymankar requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two requests:

  1. Please add tests, I think we don't really need to integration test this, but unit testing should be trivial.
  2. Please upgrade ormolu (should work with stack install ormolu from root of the repo) and reformat.

services/brig/src/Brig/Options.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Calling/API.hs Outdated Show resolved Hide resolved
@jschaul jschaul force-pushed the feature/limit-sft-server-list branch from 8ac3964 to 08753d8 Compare September 24, 2020 17:46
@jschaul jschaul force-pushed the feature/limit-sft-server-list branch from 336b86c to c265212 Compare September 28, 2020 15:02
@jschaul jschaul merged commit 32f7adc into develop Sep 29, 2020
@jschaul jschaul deleted the feature/limit-sft-server-list branch September 29, 2020 09:57
@jschaul jschaul mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschaul @akshaymankar