Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add libtinfo/ncurses to docs and nix deps #1215

Merged
merged 5 commits into from
Oct 7, 2020
Merged

add libtinfo/ncurses to docs and nix deps #1215

merged 5 commits into from
Oct 7, 2020

Conversation

mheinzel
Copy link
Contributor

@mheinzel mheinzel commented Oct 6, 2020

proto-lens-protoc switched to ghc-source-gen, which requires libtinfo.

Don't know what the equivalent on macOS is and if it's even needed. Didn't find it with some googling.
Also not sure if the Nix dependency is the right one. Please tell me if it's not right.

@mheinzel
add libtinfo/ncurses to docs and nix deps
f45ae1f 
proto-lens-protoc switched to ghc-source-gen, which requires libtinfo.
@fisx
Copy link
Contributor

fisx commented Oct 7, 2020

@mheinzel writes:

Also, we can probably remove

We are currently on a snapshot that uses ghc863 but Nix only ships ghc864 as ghc863 is officially deprecated. The releases should be totally compatible, but we need to convince stack that this is true. Hence, we can add the following to our global stack config in ~/.stack/config.yaml

agreed! do you want to do that here?

fisx
fisx approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With or without this, this PR is good to go I think.

I haven't tried the nix change, but then again, I see it working every day on debian + nix-pkg, and I think we also have it working on nixos (or @arianvp would have complained, no?).

@arianvp
Copy link
Contributor

arianvp commented Oct 7, 2020

The nix bit doesn't work anymore. Lets see if bumping nixpkgs fixes it....

arianvp and others added 3 commits October 7, 2020 10:47
@arianvp
chore: niv update
771c59d 
Otherwise libcryptobox wouldn't compile for me
@arianvp
chore: niv modify nixpkgs --repo nixpkgs
8e0b5f8 
nixpkgs-channels repo is deprecated and will be removed. Channels are
now tracked as branches in the nixpkgs repository. Lets move before this
stops working
@mheinzel
fix and generalize instruction for Nix
73e9dfd
@mheinzel
Copy link
Contributor Author

mheinzel commented Oct 7, 2020

agreed! do you want to do that here?

I didn't remove it, but made it more general since a similar situation could happen again, right?

Does the Nix setup work now?

@mheinzel mheinzel merged commit 457c989 into develop Oct 7, 2020
@mheinzel mheinzel deleted the mheinzel/add-libtinfo-to-docs-and-scripts branch October 7, 2020 17:10
@fisx fisx mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar left review comments

@fisx fisx fisx approved these changes

@arianvp arianvp arianvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mheinzel @fisx @arianvp @akshaymankar