-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rex to this repository #1218
Conversation
|
tools/rex/Makefile
Outdated
build: rex | ||
|
||
.PHONY: publish | ||
publish: $(ACI) $(ACI).asc s3-exists/$(ACI) s3-upload/$(ACI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of those targets don't exist anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and a few more things need fixing.
- there's an include that doesn't work anymore
- we should probably stack install into
dist
as with the other tools
I'm not quite sure how rex is supposed to be packaged/used, so maybe someone else could take care of these outstanding issues with the Makefile?
1ebec06
to
1e503f4
Compare
I fixed all of the issues except for the Makefile. Once that's done, this PR should be ready.
Kim worked for Wire when writing this code, so we can go ahead without the CLA. |
I added two commits here to put the Makefile in order, add a README, and also to compile a static version based on the current GHC/alpine docker image. |
@akshaymankar any further concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Ties availability of rex to that of restund -- necessary for uptime alerts
Also remove the docker volume sharing of ~/.stack (only properly works on macOS, creates conflicts on linux) and use quay.io/wire base image.
ff30f56
to
8918b2e
Compare
See https://github.com/zinfra/backend-issues/issues/1264.
I have not tried running it yet, but it compiles with the current snapshot.