Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spar: Forward errors from brig #1251

Merged
merged 12 commits into from
Nov 25, 2020
Merged

Spar: Forward errors from brig #1251

merged 12 commits into from
Nov 25, 2020

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Nov 18, 2020 •
edited
Loading

@smatting
Copy link
Contributor Author

All integration tests pass locally

@fisx fisx force-pushed the smatting/spar-better-errors branch from 4682176 to f8c1b1a Compare November 23, 2020 10:53
fisx
fisx approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! I made a few small commits, and I think logging everything in rethrow with level Error is a mistake. The other two comments are safe to ignore. :-)

Please take another look and merge if you're happy.

services/spar/src/Spar/Error.hs Outdated Show resolved Hide resolved
services/spar/src/Spar/Error.hs Show resolved Hide resolved
services/spar/src/Spar/Intra/Galley.hs Outdated Show resolved Hide resolved
@fisx
Copy link
Contributor

fisx commented Nov 23, 2020

integration tests passed locally.

@smatting
Copy link
Contributor Author

Locally testUserUpdate from brig's integration test keep failing. Need to investigate..

@fisx fisx mentioned this pull request Nov 25, 2020
Merged
@smatting smatting merged commit c3cd0ba into develop Nov 25, 2020
@smatting smatting deleted the smatting/spar-better-errors branch November 25, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @fisx