App-Lock follow-up

[smatting]

Implements
https://wearezeta.atlassian.net/browse/SQSERVICES-80

[fisx]

can you please make config changes optional? this makes migration easier in general, and will help us get this to staging more quickly.

[fisx]

actually, not sure about the config thing i said any more. your approach is very elegant. i'll leave in my comments for now, let's fight over this! :)

[fisx]

ah, and please run all the test. or at least compile everything. :)

galley-types                > /home/mf/src/wire-server/libs/galley-types/test/unit/Test/Galley/Types.hs:63:5: error:
galley-types                >     • Couldn't match type ‘Defaults
galley-types                >                              (Wire.API.Team.Feature.TeamFeatureStatus
galley-types                >                                 'Wire.API.Team.Feature.TeamFeatureAppLock)
galley-types                >                            -> FeatureFlags’
galley-types                >                      with ‘FeatureFlags’
galley-types                >       Expected type: FeatureSSO  
galley-types                >                      -> FeatureLegalHold -> FeatureTeamSearchVisibility -> FeatureFlags
galley-types                >         Actual type: FeatureSSO  
galley-types                >                      -> FeatureLegalHold
galley-types                >                      -> FeatureTeamSearchVisibility
galley-types                >                      -> Defaults 
galley-types                >                           (Wire.API.Team.Feature.TeamFeatureStatus
galley-types                >                              'Wire.API.Team.Feature.TeamFeatureAppLock)
galley-types                >                      -> FeatureFlags
galley-types                >     • Probable cause: ‘FeatureFlags’ is applied to too few arguments
galley-types                >       In the first argument of ‘(<$>)’, namely ‘FeatureFlags’
galley-types                >       In the first argument of ‘(<*>)’, namely
galley-types                >         ‘FeatureFlags <$> QC.elements [minBound .. ]’
galley-types                >       In the first argument of ‘(<*>)’, namely
galley-types                >         ‘FeatureFlags <$> QC.elements [minBound .. ]
galley-types                >            <*> QC.elements [minBound .. ]’
galley-types                >    |                             
galley-types                > 63 |     FeatureFlags            
galley-types                >    |     ^^^^^^^^^^^^            

[smatting]

@fisx approved