Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdP permissions #1274

Merged
merged 4 commits into from
Dec 8, 2020
Merged

IdP permissions #1274

merged 4 commits into from
Dec 8, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Dec 7, 2020

@fisx
Copy link
Contributor Author

fisx commented Dec 7, 2020

I tested the last 3 commits locally. the new test case fails as expected, with the fix it passes, and with the adjustment of the other tests, all unit and integration tests pass.

@fisx fisx requested a review from smatting December 7, 2020 09:24
@fisx fisx merged commit b17144f into develop Dec 8, 2020
@fisx fisx deleted the fisx/idp-permissions branch December 8, 2020 12:58
@fisx fisx mentioned this pull request Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisx @smatting