Allow admins to create/delete/list SCIM tokens #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
requested changes
Dec 9, 2020
| @@ -49,6 +49,7 @@ module Spar.Intra.Brig | |||
| createBrigUserNoSAML, | |||
| updateEmail, | |||
| getZUsrOwnedTeam, | |||
| authorizeScimTokenManagement, | |||
There was a problem hiding this comment.
Why not Spar.Intra.Galley.assertHasPermission?
There was a problem hiding this comment.
authorizeScimTokenManagement uses Spar.Intra.Galley.assertHasPermission
Can't use Spar.Intra.Galley.assertHasPermission directly because the team of the user has to be fetched first.
fisx
approved these changes
Dec 18, 2020
|
If you have run all tests locally: |
smatting
force-pushed
the
smatting/admin-scim-tokens
branch
from
6ecbd1f to
7e33c2d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.