Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servantify /self endpoint #1283

Merged
merged 12 commits into from
Dec 15, 2020
Merged

servantify /self endpoint #1283

merged 12 commits into from
Dec 15, 2020

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Dec 9, 2020 •
edited
Loading

  • move /self endpoint to servant & swagger 2.0
  • expose qualified_id field for GET /self:
 "qualified_id": {
    "id": "00000000-0000-0000-0000-000000000000",
    "domain": "string"
  }

@jschaul jschaul force-pushed the federation-self branch 4 times, most recently from 4000cd6 to 5e9a160 Compare December 14, 2020 11:24
@jschaul jschaul marked this pull request as ready for review December 14, 2020 14:59
akshaymankar
akshaymankar approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@jschaul
fix handle test: incorrect /users?handles= parsing"
670a598 
The json from /users?handles=... is a 'UserProfile' object, yet it was
incorrectly parsed implictly as a 'User' object with the use of
'userHandle' function. This test faiure occurred due to the addition of
the now mandatory qualified_id field in the mostly-internal 'User'
object (which is shown only to /self)
@jschaul jschaul merged commit 05bcd71 into develop Dec 15, 2020
@jschaul jschaul deleted the federation-self branch December 15, 2020 00:12
@fisx fisx mentioned this pull request Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschaul @akshaymankar