Add helm chart for the federator #1317
Conversation
| spec: | ||
| type: ClusterIP | ||
| ports: | ||
| # TODO: Do we name it something else to get the _correct_ SRV record? |
There was a problem hiding this comment.
I don't quite understand this TODO comment. What does the kubernetes port name have to do with SRV records? Naming this port http seems fine to me. Do we use the port name somewhere else?
There was a problem hiding this comment.
When we call this port http, kubernetes will create SRV record as _http._tcp.federator.<namespace>.cluster.local.
I assume for discovering remote federators, we will rely on an SRV record like _wire-federator._tcp.<domain>.
So, if we rename this port from http to wire-federator and configure domain as federator.<namespace>.cluster.local we will be able to test federation in same kubernetes cluster without having to mess with global DNS records. All of this is obviously not thought through, so I would much rather tackle it later. I will remove this TODO and write this information in some issue in JIRA.
| internalPort: 8080 | ||
|
|
||
| resources: | ||
| # FUTUREWORK: come up with numbers which didn't appear out of thin air |
There was a problem hiding this comment.
I think we can probably leave the resources block entirely empty: resources: {}.
But I'm also okay to follow the other charts and to make a change for all charts at once regarding resource usage, instead of only for the federator.
There was a problem hiding this comment.
Yeah, let's do them all together.
| @@ -9,3 +9,4 @@ tags: | |||
| team-settings: false | |||
| account-pages: false | |||
| legalhold: false | |||
| federator: false | |||
There was a problem hiding this comment.
Do we want to disable installing this compoent by default, and enable it once the implementation is more "ready"? Or do you want to keep this false also going forward?
There was a problem hiding this comment.
Yes, I was thinking we shouldn't enable it by default at least until it is useful. Even when it is useful, maybe we shouldn't deploy it when federation is not enabled.
https://wearezeta.atlassian.net/browse/SQCORE-364