Use mu-haskell to implement one initial federation request across backends #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
force-pushed
the
mu
branch
5 times, most recently
from
c004c87 to
63cc26d
Compare
Also attempt (only half-successfully) to massage Monad stacks. Help needed here.
* make use of, polysemy-ify, and unit test 'federateWith'
fisx
reviewed
Feb 16, 2021
This makes the use more futureproof as it guards against any cleanup the `withResolver` function might want to do after a resolver is used. This means the whole federator needs to run inside `withResolver`, but I cannot really see any downsides to this.
Co-authored-by: fisx <mf@zerobuzz.net>
fisx
reviewed
Feb 16, 2021
There was a problem hiding this comment.
General question: can we move https://github.com/wearezeta/documentation/blob/master/topics/federation/federation-design.md to wire-server/docs now? Or to wire-docs? The documentation repo is deprecated by confluence anyway.
More review chunks coming up!
Co-authored-by: fisx <mf@zerobuzz.net>
jschaul
commented
Feb 16, 2021
jschaul
commented
Feb 16, 2021
LocalCall -> Request RemoteCall -> FederatedRequest RouteToRemote -> Outward RouteToLocal and RouteToInternal -> Inward Function names have also been adjusted in many places. We still have modules externalServer internalServer and 'Remote' in federator. Perhaps we should also rename the 'remote' module?
akshaymankar
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
As decided in the call, let's merge this.
@fisx (or others) feel free to continue to review this, let's try to incorporate the changes in further PRs.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/wireapp/wire-server/blob/db4c2351476c713f0367cee635faaaea10f9adf5/docs/reference/federation/pull-requests/1319_initial_federation_request_across_backends.md
This PR might be best viewed with a filter only for .hs and .proto files.