Fix bug: SCIM-Deleting a user retains the externalId #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatting
changed the title
|
All |
|
All spar and brig integration tests pass locally after merge. |
|
Failing test is flaky un most likely unrelated https://wearezeta.atlassian.net/browse/SQSERVICES-189 |
arianvp
pushed a commit
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this bug:
Deleting a user via SCIM when there is no IdP won't remove the entry from
spar.scim_external_ids.This might be a cause for issues such as SQSERVICES-179
The test
testDeletedUsersFreeExternalIdNoIdpproves the bug and the fix.The function
userToExternalIdwas removed because its name is misleading. The only call site of this function is refactored.