Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brig integration tests: Replace federation guard with env var #1346

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Brig integration tests: Replace federation guard with env var #1346

merged 1 commit into from
Jan 29, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Jan 28, 2021 •
edited
Loading

Tasty doesn't allow multiple -p arguments.
That's why -p "!/brig-federation/" breaks any -p arguments in WIRE_INTEGRATION_TEST_OPTIONS.

This PR fixes this by guarding the federation test with an INTEGRATION_FEDERATION_TESTS env var.

@smatting smatting requested a review from jschaul January 28, 2021 17:38
@smatting smatting changed the title Brig integartion tests: Replace federation guard with env var Brig integration tests: Replace federation guard with env var Jan 28, 2021
@smatting smatting merged commit a7226b6 into develop Jan 29, 2021
@smatting smatting deleted the smatting/2021-01-08-federation-tasty-args branch January 29, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @jschaul