Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildah: Use correct dist directory while building docker-images [skip-ci] #1352

Merged
merged 1 commit into from
Feb 8, 2021
Merged

buildah: Use correct dist directory while building docker-images [skip-ci] #1352

merged 1 commit into from
Feb 8, 2021

Conversation

akshaymankar
Copy link
Member

No description provided.

@akshaymankar akshaymankar requested a review from jschaul February 8, 2021 11:03
jschaul
jschaul approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good catch, this must have slipped through my refactoring, this was fixed at some point :)

@jschaul
Copy link
Member

jschaul commented Feb 8, 2021

(I think concourse expects [skip ci] or [ci skip] without a dash)

@akshaymankar
Copy link
Member Author

(I think concourse expects [skip ci] or [ci skip] without a dash)

I consistently keep falling for this one! 🙈

@akshaymankar akshaymankar merged commit 111a0bf into develop Feb 8, 2021
@akshaymankar akshaymankar deleted the akshaymankar/buildah-dist-fix branch February 8, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaymankar @jschaul