Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for deriving-swagger2 #1373

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Add docs for deriving-swagger2 #1373

merged 4 commits into from
Feb 18, 2021

Conversation

akshaymankar
Copy link
Member

No description provided.

@akshaymankar akshaymankar requested a review from jschaul February 17, 2021 10:45
@akshaymankar
Copy link
Member Author

Looks like this:

image

jschaul
jschaul approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for documenting this module nicely!

libs/deriving-swagger2/src/Deriving/Swagger.hs Outdated Show resolved Hide resolved
libs/deriving-swagger2/src/Deriving/Swagger.hs Show resolved Hide resolved
libs/deriving-swagger2/src/Deriving/Swagger.hs Outdated Show resolved Hide resolved
libs/deriving-swagger2/src/Deriving/Swagger.hs Outdated Show resolved Hide resolved
akshaymankar and others added 3 commits February 18, 2021 08:52
@akshaymankar @jschaul
Deriving.Swagger: Fix comment
19c656a 
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
@akshaymankar @jschaul
Deriving.Swagger: Punctuation!
6511f00 
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
@akshaymankar @jschaul
Deriving.Swagger: Punctuation!
4668fff 
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
@akshaymankar akshaymankar merged commit 0c59714 into develop Feb 18, 2021
@akshaymankar akshaymankar deleted the akshaymankar/document-deriving-swagger2 branch February 18, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaymankar @jschaul