Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update move-team with upstream schema changes #1423

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Update move-team with upstream schema changes #1423

merged 3 commits into from
Apr 28, 2021

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Mar 25, 2021 •
edited
Loading

This PR updates the move-team tool:

  • remove brig.id_mapping
  • remove spar.scim_external_ids
  • add spar.scim_external
  • add spar.user
  • Update table row types from latest cassandra schema

@smatting smatting requested a review from fisx March 25, 2021 09:47
@fisx
Copy link
Contributor

fisx commented Mar 31, 2021

CI error seems to be legit (import issue in Work.hs in move-team).

fisx
fisx reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • description lacks "add spar.user".
  • have you tested the new script? (If not I want to do it.)
  • otherwise LGTM!

@smatting
Copy link
Contributor Author

smatting commented Apr 28, 2021 •
edited
Loading

  • have you tested the new script? (If not I want to do it.)

Yes if tested I created an export (but only on the subset of tables that changed).

Feel free to merge if you approve

@fisx fisx merged commit e6e95f9 into develop Apr 28, 2021
@fisx fisx deleted the smatting/2021-03-25-update-move-team branch April 28, 2021 12:18
This was referenced May 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smatting @fisx