hack/bin/integration-cleanup.sh: Use jq magic instead of bash #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the the bash expression to calculate time fails in CI and helm now supports outputting json, so I swapped bash magic with jq magic. It more robust, hopefully it is also more understandable.
lucendio
approved these changes
Apr 6, 2021
| ) | ||
| | select ( .parsedTime < (now - 3 * 60 * 60)) | ||
| | [.name, .namespace] | ||
| | @tsv |
There was a problem hiding this comment.
I think jq can either output a json array, a csv or a tsv. Out of these I thought tsv was the most compatible with bash as I can awk '{print $1}'. Do you have a better idea?
There was a problem hiding this comment.
I just stumbled upon it and was curious, as FS usually defaults to space.
fisx
reviewed
Apr 6, 2021
| date_s=$(date_seconds "$date_str") | ||
| diff=$(( $date_now - $date_s )) | ||
| if [ $diff -ge 7200 ]; then | ||
| echo "test release '$name' older than 2 hours; deleting..." |
There was a problem hiding this comment.
wanna keep that echo statement in some modified form?
jschaul
approved these changes
Apr 6, 2021
|
The tests are failing because this incorrectly deletes releases deployed less than 2 hours ago, I will look into that. |
|
Maybe I was a fool to assume jq is safer than bash 😢 c225f41 |
|
All green now, it seems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the the bash expression to calculate time fails in CI and helm
now supports outputting json, so I swapped bash magic with jq magic. It more
robust, hopefully it is also more understandable.