More federation-aware API endpoints in brig #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federation-not-enabled now gives 400
`lookupProfile` is now making one federated request for every non-local domain in the input list of qualified user ids. The logic that partitions the list by domain has been moved away from the Federation module into the corresponding API module (`Brig.API.User`).
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/federation
branch
from
05c1bbf to
373a942
Compare
Also add a test for the `/list-user` endpoint.
pcapriotti
force-pushed
the
pcapriotti/federation
branch
from
0007ed6 to
05400d6
Compare
pcapriotti
changed the title
jschaul
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Looks good! See minor inline nitpicks.
I suppose that some of the changes we touched upon in discussions (such as moving federation API in brig to make use of more post requests and extensible types rather than lists) is a refactoring planned for a future PR?
Yes, I think it's better to do that on top of #1445. |
jschaul
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add federation API endpoints:
Hook qualified public API to federator
Tests
TODOs
make(TBD in another PR)/list-usersreturn an object