Ormolu script improvements #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that ormolu returns exit code 0 on SIGTERM, and this causes the ormolu script to not react to Ctrl-C, if the ormolu process happens to receive it (as opposed to the rest of the shell script). To fix this, run ormolu in background, and wait on the corresponding process. This makes the wait call handle the interrupt, so that we can distinguish between normal failure (exit code 100), success (exit code 0) and abnormal failure.
jschaul
approved these changes
Apr 19, 2021
fisx
reviewed
Apr 25, 2021
| @@ -72,14 +72,26 @@ echo "language extensions: $LANGUAGE_EXTS" | |||
|
|
|||
| FAILURES=0 | |||
|
|
|||
| if [ -t 1 ]; then | |||
There was a problem hiding this comment.
why this trivial conditional?
anyway i like the changes!
There was a problem hiding this comment.
[ -t 1 ] returns 0 if the standard output is a tty. This check is to prevent the script from printing escape sequences when it runs in CI, or any other environment which is not a shell, basically.
There was a problem hiding this comment.
Ah, my bad: I read -t as isTrue. Checking the man page would have helped. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce size of ormolu output when running in a terminal
Make the ormolu script detect Ctrl-C more reliably