Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential pagination bug #1460

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Fix potential pagination bug #1460

merged 7 commits into from
Apr 27, 2021

Conversation

smatting
Copy link
Contributor

No description provided.

@smatting smatting requested a review from fisx April 23, 2021 15:10
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this comment?

@akshaymankar
Copy link
Member

Can a test be added to see if this is indeed a bug or not?

@fisx
Copy link
Contributor

fisx commented Apr 27, 2021

What about this comment?

(it was unrelated. the ResultSet abstraction can be used on any one page, but we still need the Page type for moving to the next page. maybe ResultSet was not the best idea ever, it's at the very best confusing.)

@fisx
Copy link
Contributor

fisx commented Apr 27, 2021

(it's not a bug, the change has no impact on behavior. but it's more clear this way.)

@fisx fisx self-requested a review April 27, 2021 09:41
@fisx fisx merged commit 9d2f229 into develop Apr 27, 2021
@fisx fisx deleted the SQSERVICES-107-fix-pagination branch April 27, 2021 12:04
This was referenced May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants